Corrected getParameterByName3

JavaScript performance comparison

Revision 10 of this test case created by rufwork

Info

getParameterByName3 would bork if other variables on the query string ended in the same text as the name of the one to return, as pointed out by a comment on SO.

Preparation code

<script>
  var query = "?pdq=wrong+search+value&q=my+search+query&value=55";

  window.GetQueryString = function(q) {
    return (function(a) {
      if (a == "") return {};
      var b = {};
      for (var i = 0; i < a.length; ++i) {
        var p = a[i].split('=');
        if (p.length != 2) continue;
        b[p[0]] = decodeURIComponent(p[1].replace(/\+/g, " "));
      }
      return b;
    })(q.split("&"));
  };

  window.getParameterByName = function(name) {
    name = name.replace(/[\[]/, "\\\[").replace(/[\]]/, "\\\]");
    var regexS = "[\\?&]" + name + "=([^&#]*)";
    var regex = new RegExp(regexS);
    var results = regex.exec(window.location.href);
    if (results == null) return "";
    else return decodeURIComponent(results[1].replace(/\+/g, " "));
  }

  window.getParameterByName2 = function(name) {
    var match = RegExp('[?&]' + name + '=([^&]*)').exec(window.location.search);
    return match && decodeURIComponent(match[1].replace(/\+/g, ' '));
  }

  window.getParameterByName3 = function(n){
      var half = location.search.split(n+'=')[1];
      return half? decodeURIComponent(half.split('&')[0]):null;
  }

  window.getParameterByName4 = function(n){
    var half = location.search.split('&'+n+'=')[1];
    if (!half) half = location.search.split('?'+n+'=')[1];
    return half? decodeURIComponent(half.split('&')[0]):null;
  }
</script>

Test runner

Warning! For accurate results, please disable Firebug before running the tests. (Why?)

Java applet disabled.

Testing in unknown unknown
Test Ops/sec
Split method
var qs = window.GetQueryString(query);

var search = qs["q"];
var value = qs["value"];
var undef = qs["undefinedstring"];
pending…
Regex method
var search = window.getParameterByName("q");
var value = window.getParameterByName("value");
var undef = window.getParameterByName("undefinedstring");
pending…
Another....
var search = window.getParameterByName2("q");
var value = window.getParameterByName2("value");
var undef = window.getParameterByName2("undefinedstring");
pending…
simplest and faster but inaccurate!
var search = window.getParameterByName3("q");
var value = window.getParameterByName3("value");
var undef = window.getParameterByName3("undefinedstring");
pending…
Corrected "simplest" but slower!
var search = window.getParameterByName4("q");
var value = window.getParameterByName4("value");
var undef = window.getParameterByName4("undefinedstring");
pending…

Compare results of other browsers

Revisions

You can edit these tests or add even more tests to this page by appending /edit to the URL. Here’s a list of current revisions for this page:

0 comments

Add a comment